Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum flattening #206

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Enum flattening #206

merged 10 commits into from
Jan 26, 2024

Conversation

escritorio-gustavo
Copy link
Contributor

@escritorio-gustavo escritorio-gustavo commented Jan 25, 2024

Refactored version of #202 created as a separate PR because their histories are not compatible

Fixes #96

@NyxCode
Copy link
Collaborator

NyxCode commented Jan 25, 2024

Amazing! The previous PR was super hard to understand (for me, at least :D). This here is now very concise, absolutely love it!

@escritorio-gustavo
Copy link
Contributor Author

It really was, I was still trying to to figure out how to generate inline_flattened for enums and it hadn't occurred to me that I could also do type intersections for structs

macros/src/types/enum.rs Show resolved Hide resolved
macros/src/types/named.rs Show resolved Hide resolved
ts-rs/tests/enum_flattening.rs Show resolved Hide resolved
@NyxCode
Copy link
Collaborator

NyxCode commented Jan 26, 2024

Awesome, thanks for the comments! From my side, I think this is ready for a merge.
Great work, i'm very happy to see support for this. Also, thanks for cleaning up the jungle of open issues & PRs!

@escritorio-gustavo escritorio-gustavo merged commit 71f4b0b into Aleph-Alpha:main Jan 26, 2024
2 checks passed
@escritorio-gustavo escritorio-gustavo deleted the enum_flattening branch January 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to generate flattened enum
2 participants