-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement inline generics #212
Implement inline generics #212
Conversation
This may have a flaw for the case where generics have both a trait bound and a default type, in which case it will keep the previous behavior. Not sure how to avoid this though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides maybe adding a small comment why there's this "null"
literal (to make exporting generic types with T::<()>::decl()
work, right?), this looks great!
Otherwise, this looks great, thanks!
Yes, when exporting the struct itself, |
The reason for this is a test that has something along the lines of |
I think that's fine for now, this PR is still an improvement on the status quo. Maybe we should create an issue for this, together with an ignored test case, so that we dont forget about this? |
That might be the best way to go. Btw, I tried an aproach using |
This actually happens in case either a default type or a trait bound exist, it's not necessary to have both at the same time |
The best way to solve this permanently would be a way to identify whether we are expanding a |
Implementation of inlined generics. Not 100% sure it works, but it did pass the
#[ignore]
d testFixes #56