Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #[ts(untagged)], #[ts(tag = "...")] and #[ts(tag = "...", content = "...")] #227

Merged
merged 7 commits into from
Feb 8, 2024

Conversation

escritorio-gustavo
Copy link
Contributor

The docs for the TS trait mention #[ts(untagged)], #[ts(tag = "...")] and #[ts(tag = "...", content = "...")], but they weren't actually parsed by our macros, this should fix it.

After merging this, #226 will need to be updated to also implement #[ts(untagged)] for enum variants

@escritorio-gustavo escritorio-gustavo added bug Something isn't working P-HIGH This will be treated with high priority labels Feb 8, 2024
@NyxCode
Copy link
Collaborator

NyxCode commented Feb 8, 2024

LGTM, thanks!
Just FYI: I'm super busy this month, so I'm not sure how much I'll be able to work on ts-rs in that time.

@escritorio-gustavo
Copy link
Contributor Author

Just FYI: I'm super busy this month, so I'm not sure how much I'll be able to work on ts-rs in that time.

No problem man!

@escritorio-gustavo escritorio-gustavo merged commit e352882 into main Feb 8, 2024
8 checks passed
@escritorio-gustavo escritorio-gustavo deleted the ts_tag branch February 8, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P-HIGH This will be treated with high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants