-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: #[ts(export_to = "../path")]
can cause diff_paths
to fail
#247
Conversation
#[ts(export_to = "../path")]
can cause diff_paths
to fail
I think we can dumb it down a bit, something like this. |
This comment was marked as outdated.
This comment was marked as outdated.
Turns out there is a difference, as I mentioned in #248, the
|
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Hey @NyxCode, check out this version, it does inline and simplify the cleaning of the path like in the gist you submitted. It also renames the function to |
Hey! Sorry for not responding sooner, still busy atm. Will probably stay that way until march 28th. This PR looks great! Doesn't overcomplicate anything while keeping |
No problem, take your time!
I'm a bit confused, which test should have that |
Could have worded that better, sry about that 😆 |
Don't worry about it xD |
This PR reproduces the potential for paths containing
..
to breakdiff_paths