Ignore ts-rs tests by default #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in #251, this will be kept on hold until the CLI release |
escritorio-gustavo
added
Next Major Release
CLI
|
Obsolete as of #304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ts-rs exports its TypeScript bindings in every test run. This seems to really upset some people, and with good reasons:
So this PR proposes a way to change that by adding
#[ignore]to all ts-rs tests. This enables users to:cargo testcargo test export_bindings_ -- --ignoredcargo test -- --ignored(though this does have the downside of running the user's own ignored tests)Fixes #62