Replace Record<K, V> with { [key: K]: V }

[escritorio-gustavo]

Goal

Allow recursive HashMap types by changing their inlining from Record<K, V> to { [key: K]: V }
Closes #134

Changes

The impl block for HashMap was altered

Checklist

• I have followed the steps listed in the Contributing guide.
• If necessary, I have added documentation related to the changes made.
• I have added or updated the tests related to the changes made.

[escritorio-gustavo]

I actually have no idea what this method should return. Maybe it should panic!?

[escritorio-gustavo]

Yep, it should panic. This method is only ever used if the type is derived

[NyxCode]

I think that's right!
We only use ident() for constructing Dependency, and we only do that for type which can be exported (which are those that are derived).

[NyxCode]

Awesome, thank you!

While playing with this a bit, I found one potential edge-case:

type A<K, V> = { [key: K]: V }

which would be generated by struct Wrapper<K, V>(HashMap<K, V>) doesn't compile.

However, type A<K, V> = Record<K, V>; doesn't compile either, which is what we had before.

So right now, I can't think of any regression this would cause. Are there any edge-cases you're concerned about?

[NyxCode]

As far as I can tell, I think this is a minor change (e.g 8.0.1), and shouldn't break anything.