Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert newline at end of generated files #321

Merged
merged 5 commits into from
May 22, 2024

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented May 21, 2024

Goal

Closes #320

Changes

How did you go about solving the problem?

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@lucperkins lucperkins changed the title Insert newline at end of file Insert newline at end of generated files May 21, 2024
ts-rs/src/export.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@escritorio-gustavo escritorio-gustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@escritorio-gustavo escritorio-gustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + CI passes

@escritorio-gustavo escritorio-gustavo merged commit f898578 into Aleph-Alpha:main May 22, 2024
7 checks passed
@escritorio-gustavo
Copy link
Contributor

Thanks for the PR @lucperkins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: files are missing final newlines
2 participants