Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo test export_bindings to README #363

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

dessalines
Copy link
Contributor

@dessalines dessalines commented Nov 2, 2024

Goal

This should be the main way to export bindings, as many projects have tests that can take a long time to run. For our project (lemmy), tests can take over a minute, but our javascript library doesn't actually need to run them, just generate bindings.

Context #166

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

This should be the main way to export bindings, as many projects have tests that can take a long time to run.

Context Aleph-Alpha#166
@NyxCode
Copy link
Collaborator

NyxCode commented Nov 2, 2024

Thanks! Could you make that change to the docs in lib.rs instead? We generate the README, see CONTRIBUTING.md.

@dessalines
Copy link
Contributor Author

Oops, my bad. Fixed.

@gustavo-shigueo gustavo-shigueo merged commit 592898a into Aleph-Alpha:main Nov 3, 2024
9 checks passed
@gustavo-shigueo gustavo-shigueo added the documentation Improvements or additions to documentation label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants