Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): move Self import from typing to typing_extensions #183

Merged
merged 2 commits into from
Jan 10, 2024
Merged

chore(deps): move Self import from typing to typing_extensions #183

merged 2 commits into from
Jan 10, 2024

Conversation

lfnovo
Copy link
Contributor

@lfnovo lfnovo commented Jan 4, 2024

Pacote está falhando no Collab e em outros lugares por conta da importação de Self from typing. Adicionado um pacote typing_extensions. Aproveitei a criei também um requirements.txt para que ele seja facilmente instalável via pip.

@fccoelho fccoelho requested a review from luabida January 8, 2024 18:24
@luabida
Copy link
Collaborator

luabida commented Jan 9, 2024

@lfnovo obrigado pelo PR. Olhei e parece tudo certo, mas não sei se compreendi a necessidade do arquivo requirements.txt, acredito que seja preferível utilizar o Poetry para o gerenciamento das dependências.

@luabida
Copy link
Collaborator

luabida commented Jan 10, 2024

Merging to enable usage on Colab, moving the discussion to an issue

@luabida luabida merged commit 25967b2 into AlertaDengue:main Jan 10, 2024
4 checks passed
Copy link

🎉 This PR is included in version 0.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants