✨ Stop a moving Citizens NPC when in a conversation #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BakaAless <44125445+BakaAless@users.noreply.github.com>
AlessioGr
reviewed
Feb 17, 2023
paper/src/main/java/rocks/gravili/notquests/paper/conversation/ConversationManager.java
Outdated
Show resolved
Hide resolved
paper/src/main/java/rocks/gravili/notquests/paper/conversation/ConversationManager.java
Show resolved
Hide resolved
| @@ -55,6 +52,9 @@ | |||
| import rocks.gravili.notquests.paper.structs.variables.VariableDataType; | |||
|
|
|||
| public class ConversationManager { | |||
|
|
|||
| public static final Map<Integer, List<UUID>> CONVERSATIONS_IN_PROGRESS = new HashMap<>(); | |||
There was a problem hiding this comment.
hmm what this does is not quite clear from the naming (that it stores npc IDs). Also, is it necessary, considering all open conversations are already stored in "openConversations"?
Also make sure not to use static here (or pretty much anywhere in notquests)
There was a problem hiding this comment.
Just to easily retrieve all the conversations that involve this NPC: the conversations can have several speakers and it is much more complex to retrieve the one that involves the current NPC.
Signed-off-by: BakaAless <44125445+BakaAless@users.noreply.github.com>
Signed-off-by: BakaAless <44125445+BakaAless@users.noreply.github.com>
AlessioGr
reviewed
Feb 17, 2023
paper/src/main/java/rocks/gravili/notquests/paper/conversation/ConversationManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BakaAless <44125445+BakaAless@users.noreply.github.com>
Signed-off-by: BakaAless <44125445+BakaAless@users.noreply.github.com>
Signed-off-by: BakaAless <44125445+BakaAless@users.noreply.github.com>
|
Thank you so much for this cool PR again <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All is in the title.
Minecraft_.1.19.2.-.Multiplayer.3rd-party.Server.2023-02-17.18-32-32.mp4