Export the RuleValidators type as part of the API #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ValdisThomann - thanks for your patience on this 🙂 I've just released v3.2.0 that adds the desired type exports - please let me know if you have any further issues! |
|
Awesome, thanks!
…On Wed, 6 Mar 2024, 3:52 am Alex Potter, ***@***.***> wrote:
Hi @ValdisThomann <https://github.com/ValdisThomann> - thanks for your
patience on this 🙂 I've just released v3.2.0
<https://github.com/AlexJPotter/fluentvalidation-ts/releases/tag/v3.2.0>
that adds the desired type exports - please let me know if you have any
further issues!
—
Reply to this email directly, view it on GitHub
<#47 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFKGV26CCNUCGMSMVNDUUFLYWXZ43AVCNFSM6AAAAAA7SHB4AWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZGIYTGMBUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Thanks for writing such an awesome library - I really appreciate it.
I've used it to great effect in an angular project, extending the angular
FormGroupso that you can actually have strongly-typed validation rules (instead of the OOB experience which only allows abstract rules).I was going to turn this into a little angular library, but I've hit a snag. My implementation creates a custom rule validator, which basically unpacks the value from the angular form field and passes it to
ruleForTransformed(). This works fine using the inferred type for that method when the implementation is within my consuming application. However, the compiler blows up when I try to export the type declarations for that inferred type.There's a pretty easy fix for this - it all works fine if I import
RuleValidatorsand explicitly type my custom rule validator.Would you be happy to approve this change to the API, to allow me (and others) to extend rule validators?