UUID Support #28
Open
UUID Support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexProgrammerDE can you review this please |
AlexProgrammerDE
requested changes
Jun 9, 2022
| @@ -15,9 +16,13 @@ | |||
| import java.util.logging.Logger; | |||
|
|
|||
| public final class PistonMute extends JavaPlugin { | |||
|
|
|||
| @Getter | |||
| public static Logger log; | |||
Comment on lines
+164
to
+169
| <dependency> | ||
| <groupId>commons-io</groupId> | ||
| <artifactId>commons-io</artifactId> | ||
| <version>2.11.0</version> | ||
| </dependency> | ||
|
|
There was a problem hiding this comment.
First of all the newline after this text is not needed, and secondly it has to be relocated.
Comment on lines
+24
to
+26
| @Nullable UUID uuid = null; | ||
| @Nullable UUID senderUUID = null; | ||
| @Nullable String name = null; |
There was a problem hiding this comment.
No need to mark them as nullable. They are already initialized to null.
| senderUUID = ((Player) sender).getUniqueId(); | ||
| } | ||
|
|
||
| if (args[0].matches("[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}")) { |
There was a problem hiding this comment.
Replace this with a try catch of UUID#fromString() in a utility method. I don't like hardcoding this pattern.
Comment on lines
+17
to
+62
| public class MojangUtil { | ||
|
|
||
| private static final String UUID_URL = "https://api.mojang.com/users/profiles/minecraft/%s"; | ||
| private static final String NAME_URL = "https://api.mojang.com/user/profiles/%s/names"; | ||
|
|
||
| @SneakyThrows | ||
| public static UUID getUUID(String name) { | ||
| String UUIDJson = IOUtils.toString(new URL(String.format(UUID_URL, name))); | ||
|
|
||
| if(UUIDJson.isEmpty()) return null; | ||
|
|
||
| JSONObject UUIDObject = (JSONObject) JSONValue.parseWithException(UUIDJson); | ||
|
|
||
| return UUIDTypeAdapter.fromString(UUIDObject.get("id").toString()); | ||
| } | ||
|
|
||
| @SneakyThrows | ||
| public static String getName(UUID uuid) { | ||
| String nameJson = IOUtils.toString(new URL(String.format(NAME_URL, UUIDTypeAdapter.fromUUID(uuid)))); | ||
|
|
||
| JSONArray nameValue = (JSONArray) JSONValue.parseWithException(nameJson); | ||
|
|
||
| String playerSlot = nameValue.get(nameValue.size()-1).toString(); | ||
|
|
||
| JSONObject nameObject = (JSONObject) JSONValue.parseWithException(playerSlot); | ||
|
|
||
| return nameObject.get("name").toString(); | ||
| } | ||
|
|
||
| private static class UUIDTypeAdapter extends TypeAdapter<UUID> { | ||
| public void write(final JsonWriter out, final UUID value) throws IOException { | ||
| out.value(fromUUID(value)); | ||
| } | ||
|
|
||
| public UUID read(final JsonReader in) throws IOException { | ||
| return fromString(in.nextString()); | ||
| } | ||
|
|
||
| public static String fromUUID(final UUID value) { | ||
| return value.toString().replace("-", ""); | ||
| } | ||
|
|
||
| public static UUID fromString(final String input) { | ||
| return UUID.fromString(input.replaceFirst("(\\w{8})(\\w{4})(\\w{4})(\\w{4})(\\w{12})", "$1-$2-$3-$4-$5")); | ||
| } | ||
| } |
There was a problem hiding this comment.
Excuse me, WHAT? Bukkit#getOfflinePlayer already works with uuids. It even fetches a player if none is stored locally. Check the javadoc of that method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#26