Enabled Drupal 11 CI test jobs #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannguyen04
commented
Jul 4, 2024
| @@ -80,64 +78,6 @@ protected static function getProtectedValue(object $object, string $property) { | |||
| return $property->getValue($class); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
@AlexSkrypnyk
I have removed this prepare class mock because we are not using and
sebastianbergmann/phpunit#5241
tannguyen04
commented
Jul 4, 2024
| "vincentlanglet/twig-cs-fixer": "^2.8" | ||
| }, | ||
| "config": { | ||
| "allow-plugins": { | ||
| "dealerdirect/phpcodesniffer-composer-installer": true, | ||
| "phpstan/extension-installer": true | ||
| "phpstan/extension-installer": true, | ||
| "mglaman/composer-drupal-lenient": true |
There was a problem hiding this comment.
I am using this technique https://www.drupal.org/docs/develop/using-composer/using-drupals-lenient-composer-endpoint to solve config_filter module compatibility issue.
tannguyen04
commented
Jul 4, 2024
| @@ -117,15 +117,6 @@ jobs: | |||
| DRUPAL_PROJECT_SHA: 10.x | |||
| <<: *job-test | |||
|
|
|||
| test-php-8.2-next: | |||
There was a problem hiding this comment.
I removed this because D11 does not support php8.2
tannguyen04
changed the title
AlexSkrypnyk
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
closes #37
[#123] Verb in past tense with dot at the end.Changedsection about WHY something was done if this was not a normal implementationChanged
Screenshots