Tray icons with incorrect size on fractionally scaled output

[minhduc0711]

The tray icons on the scaled monitor are weirdly sized on my scaled output

On my other unscaled output, they appear normally

Could it be related to #1174?

Version: Waybar v0.9.7-107-g1b4ddbc (branch 'master')

[luispabon]

Having the same problem:

the wifi signal icon (nm-applet) is 1/2 the size on a scale 2 display. This is from a recent update.

[Mathew-D]

If you go back to before commit 811f089 that fixes the error and the icons are the correct size. Something in that commit breaks the size on some icons.

[Mathew-D]

Also it gives this error if you use the master:
gtk_widget_set_accel_path: assertion 'GTK_IS_ACCEL_GROUP (accel_group)' failed

[luispabon]

Reverting to 67d482d fixes it for me as well.

[Alexays]

@mswiger can you take a look?

[minhduc0711]

There's a small issue left: upon first launching the bar, the icons are way bigger than it should be. They would go back to their normal size if I do something that change the icons' states (e.g. change my ibus input method).

[mswiger]

I am able to reproduce the issue that @minhduc0711 is seeing, but only with a multiple-display setup, and it does not reproduce 100% of the time (maybe like 25% of the time for me). It is relatively easy to reproduce by repeatedly reloading the Sway config file until the issue appears ($mod+Shift+c for me).

After spending a bunch of time debugging, this bug seems to behave like some kind of race condition. For tray items that take longer to populate in the tray, this issue never seems to happen. For tray items that populate quickly after waybar is loaded, this problem seems to happen pretty consistently.

From my debugging, when this issue manifests, it appears that the Image widget itself is allocating the wrong amount of space (it will allocate the scaled width/height when it should allocate the unscaled width/height). Not 100% sure how to proceed from here, but I will try to spend some more time on this later this week.

[mswiger]

@minhduc0711 I believe that I have a fix for this now: #1211

[minhduc0711]

Thank you for the quick fix, the issue is gone on my setup 🎉