Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If bar height gets very large at some point it never liberates the reserved space #799

Closed
elinorbgr opened this issue Aug 6, 2020 · 1 comment · Fixed by #824
Closed
Labels
bug Something isn't working

Comments

@elinorbgr
Copy link
Contributor

While testing some stuff, I started a demo Wayland app which set its title to some very large string, containing several newlines. As a result, waybar grew a lot in height to display the full title, including the newlines, and the space reserved for it by sway grew as well.

Once that demo app was closed, waybar returned to its normal size, but the space reserved for it by sway did not, resulting in a huge empty gap on my screen between the bar and the windows.

Looks like the reserved space in layer shell is only updated when the bar grows, but not when it shrinks?

@alebastr
Copy link
Contributor

alebastr commented Aug 6, 2020

Looks like the reserved space in layer shell is only updated when the bar grows, but not when it shrinks?

Looking at the code, that's exactly how it works when gtk-layer-shell is used. The old layer-shell code was relying on layer_surface.configure event for that, gtk-layer-shell code path is not using it and Bar::onConfigure code doesn't look right.

Need to look how to fix that without affecting fallback layer-shell code.

@Alexays Alexays added the bug Something isn't working label Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants