Fix resizing of the bar with gtk-layer-shell #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanly separate resizing logic for gtk-layer-shell and manually managed layer surface code.
Fixes warning about xdg_wm_base.version mismatch. Fixes potential crash when GTK does not expect wl_surface to be committed.
|
Perfect as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hindsight, it wasn't a good idea to have one set of GTK event handlers for both code paths. Took me a while to remember which code is needed for gtk-layer-shell and which one is for bare layer-surface. Apparently
Bar::onConfigurewasn't passing the right values tosetExclusiveZonebecause it was written with assumption thatlayerSurfaceHandleConfigurealready done everything required.At some point GTK stopped listening to
resize/set_size_requestif the requested size is insufficient. This is now causing occasional bar size changes and warnings in the log for both code paths.This would also cause an interesting behavior if
gtk-layer-shellis disabled and the bar height is a fixed value from the config file; the bar would expand according to a content size, but the exclusive zone size would stay as configured.Fixes: #799 (only for gtk-layer-shell).
Also fixes xdg_wm_base.version mismatch warning via gtk-layer-shell 0.3.0 update.