[Taskbar] Add name field #1240
Closed
[Taskbar] Add name field #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anakael
reviewed
Sep 12, 2021
|
|
||
| /* Method 1 - get the correct icon name from the desktop file */ | ||
| static std::string get_from_desktop_app_info(const std::string &app_id) | ||
| Glib::RefPtr<Gio::DesktopAppInfo> gen_app_info(const std::string app_id) |
Anakael
reviewed
Sep 12, 2021
| @@ -383,6 +390,15 @@ void Task::handle_app_id(const char *app_id) | |||
| { | |||
| app_id_ = app_id; | |||
|
|
|||
| Glib::RefPtr<Gio::DesktopAppInfo> app_info = gen_app_info(app_id); | |||
There was a problem hiding this comment.
In case missing icon and name options it will cost unnecessary overhead. And it will be searched twice, as app_info was't saved.
|
Closed due to #1221 being merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
#982
#1028
#1135
Realize as I was finishing this that this is basically an alternative solution to #1221 , however decided to post this as a PR anyway, as it seems less intrusive as an alternate solution.