time conversion between time zones #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com>
Alexays
reviewed
Jul 24, 2023
Alexays
approved these changes
Jul 24, 2023
Signed-off-by: Viktar Lukashonak <myxabeer@gmail.com>
|
Thanks! |
|
This reverts #2296, is this intentional? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Alexays , this PR should fix
The problem was here: when calendar used to print information through fmt::format it used sys_days function which doesn't care about timezones and calculates date time in UTC.
For now: the whole clock is moved to zoned logic. Even user doesn't configure his local timezone, system time zone will be used to provide info about date, time, calendar. When user configures array of timezones and switches between each other calendar will also been recalculated with applying of the picked timezone.