Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logical errors, formatting error #2373

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

marshallmoats
Copy link
Contributor

PR #2341 resulted in my workspaces not showing up. It seems this is a result of a couple minor logical mistakes (due to switching from find to starts_with), along with id not being formatted in, which was throwing an "argument not found" exception. I don't know the reasoning behind not formatting id, if anyone knows why, let me know.

@Alexays Alexays merged commit 7fb37c0 into Alexays:master Aug 2, 2023
@zjeffer
Copy link
Contributor

zjeffer commented Aug 2, 2023

@marshallmoats I can't find the review comment anymore but @MightyPlaza said the id label would not work anymore due to persistent workspaces. I can't remember why exactly, though.

EDIT: found MightyPlaza's comment about this in my emails:

persistent workspaces makes implementing label id impossible, so this should be removed and doc updated


Can you share the config you are using that caused your workspaces not showing up? I didn't have this problem.

@marshallmoats
Copy link
Contributor Author

@zjeffer Thanks for the clarification. I hadn't been using a config for that module. I now see that the issue is that the default format is {id}, apologies for the oversight. I suppose the default format should be changed from {id} to {name}, then?

@zjeffer
Copy link
Contributor

zjeffer commented Aug 2, 2023

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants