-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hyprland workspaces add sort-by #2486
Conversation
afae267
to
cbc12e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just suggesting one minor change.
I don't really have time to test this thoroughly right now, so make sure you test:
- switching between persistent workspaces
- adding new workspaces by name
- switching to special workspaces
- switching to named special workspaces
- making a (named) special workspace persistent, adding and removing the windows from it, and switching between this workspace and another: the special workspace shouldn't change position if the workspace is empty or not.
@zjeffer Updated to use an enum based approach. Sort-by overrides the sorting mechanism and falls back to previous sorting method with a warning if an incorrect value is supplied. |
a648b68
to
8ce64ea
Compare
@zjeffer new commit with changes to make it easier for other classes to use. There are a few different config related things we could probably create an issue / PR to discuss and brainstorm some more ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just some small suggestions left:
Sounds good, I also realized I now need to make sure the keys are uppercase so i'll add a commit to make that work since people can provide their own keys. Just trying to make it so you dont have to worry about case when a person is writing their config. |
eb11b6a
to
3ae2fe3
Compare
@zjeffer appreciate the thorough review... learned a few things :) |
74d20ae
to
79cf33b
Compare
@zjeffer Alright, handled those last couple suggestions. |
@Alexays This one should be ready, now. |
LGTM, thx to both of you! |
Closes: #2474
Adds a
sort-by
option that takes in a string to choose how to sort workspaces. This allows you to manually specify the sorting method and future sorting methods can just utilize the same config option. Fallsback to the original sorting.