-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON parsing with hexadecimal characters #2496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace \x with \u00 to follow JSON spec * fixes Alexays#2475 and Alexays#2495 * added unit tests for json parsing
zjeffer
changed the title
Added tests for json parsing
Fix JSON parsing with hexadecimal characters
Jan 14, 2024
@Nyayurn can you test if you still have your bug with this new parser? |
It's fine |
Can you show the console output, I'd like to see if there are any errors from the clock component. |
@Alexays This is ready to be reviewed. |
LGTM, thx for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2495 and #2475
The JSON spec doesn't allow characters like
\xab
. Instead, it should be converted to unicode:\u00ab
.It's my first time writing catch2 tests, let me know if I did something wrong.