Revise cava module to hide on silence #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukashonakV
reviewed
Oct 9, 2023
|
I added the explanation to the man file. I will change the wiki as well once all discussion and review is done and you accepted the modification. Thanks! |
|
Thanks, can you also update the GitHub wiki? |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, this is a great project, thank you! It urged me to contribute....
I added to the cava module a configuration option
hide_on_silence. If it is set totruethe cava label is hidden if no sound is played aftersleep_timerseconds.If the option is not specified or set to
falsethe bahaviour is unchanged (current behaviour, no hiding).