Add basic tests for SleeperThread #2608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taminob
force-pushed
the
feature/add-tests-for-sleeper-thread
branch
9 times, most recently
from
d2e9c5f to
e5cd237
Compare
This allows compilation of "include/util/command.hpp" without the main source file.
This library can be linked to the main executable and the test executable.
taminob
force-pushed
the
feature/add-tests-for-sleeper-thread
branch
from
e5cd237 to
a0db413
Compare
|
I don't think anymore that these @Alexays if you think the other changes to allow linking against a static waybar lib in the tests are worth adding, feel free to ping me and I can open another PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote these after failing to construct test cases for #2601.
Unfortunately, I couldn't think of tests without relying on some timing, but I hope that I chose the times so that the tests will work on all (relevant) systems.
For this, I restructured the build system to allow for easier addition to the tests by compiling all sources of waybar (except
main.cpp) as a static library.This library is then linked against
main.cppfor the main executable and against the test files for the test executable.