Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement windows formating in sway/workspaces #2773

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

grimpy
Copy link
Contributor

@grimpy grimpy commented Dec 27, 2023

This implementation mimics to some extend the implementation of hyprland

@grimpy grimpy force-pushed the waybarwindows branch 7 times, most recently from 7e3d106 to 660f5bd Compare December 30, 2023 08:40
This implementation mimics to some extend the implementation of hyprland

Signed-off-by: Jo De Boeck <deboeck.jo@gmail.com>
@grimpy
Copy link
Contributor Author

grimpy commented Feb 3, 2024

@Alexays anything else you want me to address in this PR?

@Alexays
Copy link
Owner

Alexays commented Feb 19, 2024

LGTM, can you also update the Github wiki?

@Alexays Alexays merged commit ae1e11d into Alexays:master Feb 19, 2024
8 of 9 checks passed
@Alexays
Copy link
Owner

Alexays commented Feb 19, 2024

Reverted, freebsd check failed.

@alebastr
Copy link
Contributor

../src/modules/sway/workspaces.cpp:250:20: error: no member named 'any_of' in namespace 'std::ranges'
  if (std::ranges::any_of(node["nodes"], [&](auto const &e) { return hasFlag(e, flag); })) {
      ~~~~~~~~~~~~~^

The CI runs FreeBSD 13.2 (still supported) with clang 14.x. It either has no std::ranges support or may need additional includes. Rewriting this line with std::any_of would be better for compatibility (and for the binary size).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants