Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: drawer not appearing on configured side #2881

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

jramrath
Copy link
Contributor

@jramrath jramrath commented Feb 2, 2024

See #2875

@jramrath
Copy link
Contributor Author

jramrath commented Feb 4, 2024

Turns out we can't remove the transition_type handling. I've added this comment:

/* The transition direction of a drawer is not actually determined by the transition type,
 * but rather by the order of 'box' and 'revealer_box':
 *   'REVEALER_TRANSITION_TYPE_SLIDE_LEFT' and 'REVEALER_TRANSITION_TYPE_SLIDE_RIGHT'
 *   will result in the same thing.
 * However: we still need to differentiate between vertical and horizontal transition types.
 */

@jramrath jramrath marked this pull request as ready for review February 4, 2024 15:28
@Alexays Alexays merged commit b6f4a0d into Alexays:master Feb 6, 2024
@Alexays
Copy link
Owner

Alexays commented Feb 6, 2024

LGTM thx.

@jramrath jramrath deleted the drawer-direction branch February 6, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants