Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make battery estimate inaccessible in the "Full" state on default config #2899

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

OpenSauce04
Copy link
Contributor

@OpenSauce04 OpenSauce04 commented Feb 8, 2024

Fixes #2893

This PR makes it so that, when the battery module is in the Full state, the battery life estimate is inaccessible similarly to how the module acts in the Charging and Plugged states.

This is done by adding a line in the default config which sets a format for the Full state. Setting a format for a given state disables access to the format-alt display while that state is active.

There are possibly better ways to approach this than a config change, but I couldn't think of any that wouldn't limit the functionality of other configs that may use format-alt here for things other than displaying a battery estimate, in which case the issue wouldn't occur.

If there is a better solution to this problem, please let me know and I'll look into that instead.

@Alexays Alexays merged commit 4d076a7 into Alexays:master Feb 9, 2024
@Alexays
Copy link
Owner

Alexays commented Feb 9, 2024

LGTM, thx

@OpenSauce04 OpenSauce04 deleted the battery-full-no-alt branch February 9, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Battery time estimate is viewable while charging at 100%, leading to very large/ broken time estimates
2 participants