Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for tooltip-format for custom modules #2923

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Add check for tooltip-format for custom modules #2923

merged 2 commits into from
Feb 19, 2024

Conversation

jones-josh
Copy link
Contributor

Issue #2914 tries to use tooltip-format on a custom module without a script. This change results in tooltip-format entries in config being used as the tooltip format, over any tooltip-related return from the output of a custom script if there is one.

This makes the most sense to me as it is the more visible change. If I see a tooltip-format entry in the config file, I expect that this is truth, not the output of a script in a different place. While it wouldn't be best practice to setting the tooltip in both places, I'd argue that a user would expect that their change to the config would be reflected in the case of using a 3rd party script they don't fully understand.

@jones-josh
Copy link
Contributor Author

Of course will add to man and wiki as appropriate if approved of.

@Alexays
Copy link
Owner

Alexays commented Feb 16, 2024

LGTM

@jones-josh
Copy link
Contributor Author

Will add to wiki once merged

@Alexays Alexays merged commit 9191cae into Alexays:master Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants