Add check for tooltip-format for custom modules #2923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2914 tries to use
tooltip-format
on a custom module without a script. This change results intooltip-format
entries in config being used as the tooltip format, over any tooltip-related return from the output of a custom script if there is one.This makes the most sense to me as it is the more visible change. If I see a
tooltip-format
entry in the config file, I expect that this is truth, not the output of a script in a different place. While it wouldn't be best practice to setting the tooltip in both places, I'd argue that a user would expect that their change to the config would be reflected in the case of using a 3rd party script they don't fully understand.