build: refactorings and deprecation fixes #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `<experimental/filesystem>` and `-lc++experimental` aren't needed since LLVM 9.0. And since we now require C++20, checking for the `<filesystem>` support shouldn't be necessary either.
We already use it without checking (`<gio/gdesktopappinfo.h>` in wlr/taskbar), it's a transitive dependency of GTK and it's always available on Unix platforms.
- `ExternalProgram.path` - `dependency.get_pkgconfig_variable` - `meson.build_root` - `meson.source_root`
alebastr
commented
Feb 17, 2024
alebastr
force-pushed
the
meson-cleanup
branch
from
80fd3f2 to
382039f
Compare
The library tests take more time to complie than the entire Waybar.
``` ../include/util/css_reload_helper.hpp:15:7: warning: 'class waybar::CssReloadHelper' has virtual functions and accessible non-virtual destructor [-Wnon-virtual-dtor] ```
alebastr
force-pushed
the
meson-cleanup
branch
from
382039f to
543290a
Compare
alebastr
force-pushed
the
meson-cleanup
branch
from
585becc to
a95b6a3
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.