pulseaudio: volume indicator update on default output switch #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixed clang format, but had to touch another file unrelated to my changes to make it work |
Alexays
force-pushed
the
master
branch
2 times, most recently
from
d623a89 to
a4d31ab
Compare
on sinkInfo callbacks, the default sink now has highest priority. That fixes an issue that the volume indicator is not updated when the changes the default output to another devices. added PA_SINK_IDLE as valid state. PA_SINK_RUNNING is only true if any sound output is happening on sink switch. Indicator should also update when no sound is being played.
workflow dispatch to debug failing workflow manually
findus
force-pushed
the
pulseaudio-default-sink
branch
from
2ce7620 to
57156bc
Compare
|
Is there a reason why this still hasn't been merged into main? It's a bit odd that you can't swap outputs with pavucontrol if you want waybar to recognise it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the volume indicator does not update when the default output device changes.
I fixed it by saving the current default sink (and its state) and check on every sink-update-callback if the original sink is still present and active (Idle or Running).
If that is the case, every callback from other sinks are ignored.
Example:
Top Bar: new
Bottom Bar: current master
Fixes: #605
example2.mp4