Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyprland/backend: drop unnecessary getaddrinfo call #3527

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

alebastr
Copy link
Contributor

Hyprland hasn't been using TCP sockets for IPC since the first release, so this getaddrinfo call and its result was never needed.

Additionally, it leaks the aiRes, causing test failure under ASan.

Not tested on a real Hyprland, but see hyprwm/Hyprland@39a9980.

CC: @khaneliman

Hyprland hasn't been using TCP sockets for IPC since the first release,
so this getaddrinfo call and its result was never needed.

Additionally, it leaks the `aiRes`, causing test failure under ASan.
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Alexays Alexays merged commit f665d1d into Alexays:master Aug 26, 2024
8 of 9 checks passed
@alebastr alebastr deleted the hypr-getaddrinfo branch September 1, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants