Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return app_identifier as itself in AAppIconLabel if it's an absolute path #3613

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

ThatOneCalculator
Copy link
Contributor

If an app's identifier is an absolute path, return said path. This is for apps like tidal-hifi that identify itself as /usr/share/icons/tidal-hifi/tidal-hifi.png. Closes #3612

@ThatOneCalculator ThatOneCalculator marked this pull request as draft September 15, 2024 23:50
@ThatOneCalculator ThatOneCalculator marked this pull request as ready for review September 16, 2024 00:20
@ThatOneCalculator
Copy link
Contributor Author

Tested and works

@Alexays Alexays merged commit ae997ad into Alexays:master Sep 16, 2024
@Alexays
Copy link
Owner

Alexays commented Sep 16, 2024

Thanks!

@ThatOneCalculator ThatOneCalculator deleted the fix/3612 branch September 16, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Window] window application icon doesn't work for absolute path
2 participants