Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsafe annotations for the options API. #139

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Remove unsafe annotations for the options API. #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lexical-parse-float/src/bigint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ impl<const SIZE: usize> StackVec<SIZE> {
///
/// Safe if `self.len() < self.capacity()`.
#[inline(always)]
pub unsafe fn push_unchecked(&mut self, value: Limb) {
unsafe fn push_unchecked(&mut self, value: Limb) {
debug_assert!(self.len() < self.capacity());
// SAFETY: safe, capacity is less than the current size.
unsafe {
Expand Down Expand Up @@ -419,7 +419,7 @@ impl<const SIZE: usize> StackVec<SIZE> {
///
/// Safe if `self.len() > 0`.
#[inline(always)]
pub unsafe fn pop_unchecked(&mut self) -> Limb {
unsafe fn pop_unchecked(&mut self) -> Limb {
debug_assert!(!self.is_empty());
// SAFETY: safe if `self.length > 0`.
// We have a trivial drop and copy, so this is safe.
Expand All @@ -445,7 +445,7 @@ impl<const SIZE: usize> StackVec<SIZE> {
///
/// Safe if `self.len() + slc.len() <= self.capacity()`.
#[inline(always)]
pub unsafe fn extend_unchecked(&mut self, slc: &[Limb]) {
unsafe fn extend_unchecked(&mut self, slc: &[Limb]) {
let index = self.len();
let new_len = index + slc.len();
debug_assert!(self.len() + slc.len() <= self.capacity());
Expand Down Expand Up @@ -1228,6 +1228,7 @@ pub fn large_mul<const SIZE: usize>(x: &mut StackVec<SIZE>, y: &[Limb]) -> Optio
// multiplication.
if y.len() == 1 {
// SAFETY: safe since `y.len() == 1`.
// NOTE: The compiler does not seem to optimize this out correctly.
small_mul(x, unsafe { index_unchecked!(y[0]) })?;
} else {
*x = long_mul(y, x)?;
Expand Down Expand Up @@ -1369,6 +1370,7 @@ pub fn shl_limbs<const SIZE: usize>(x: &mut StackVec<SIZE>, n: usize) -> Option<
let x_len = x.len();
let ptr = x.as_mut_ptr();
let src = ptr;
// FIXME: Change to `split_at_mut` and `clone_from_slice`?
// SAFE: since x is not empty, and `x.len() + n <= x.capacity()`.
unsafe {
// Move the elements.
Expand Down
Loading