Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds statsd/graphite Based Telemetry for Nomad #319

Merged
merged 17 commits into from
Jun 18, 2018
Merged

Conversation

Miserlou
Copy link
Contributor

Issue Number

#54

Purpose/Implementation Notes

This adds statsd+graphite based telemetry to Nomad. This will be necessary for understanding the cpu/disk/memory resource usages of active systems so that we can further refine our usage job specifications.

Types of changes

  • New feature (non-breaking change which adds functionality)

Functional tests

Not applicable, but tested locally.

Can be tested locally by running:

docker run -d\
 --name graphite\
 --restart=always\
 -p 80:80\
 -p 2003-2004:2003-2004\
 -p 2023-2024:2023-2024\
 -p 8125:8125/udp\
 -p 8126:8126\
 graphiteapp/graphite-statsd

then adding this to local nomad config:

telemetry {
  publish_allocation_metrics = true
  publish_node_metrics       = true
  statsd_address = "localhost:8125"
}

and visiting localhost:80 in the browser.

Checklist

Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

screen shot 2018-06-15 at 1 06 05 pm

@ghost ghost assigned Miserlou Jun 15, 2018
@cgreene cgreene added this to the Keytar Kurt milestone Jun 18, 2018
Copy link
Contributor

@kurtwheeler kurtwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm curious if it's possible for the lead server to publish stats on itself as well or is that a chicken and egg type problem?

@Miserlou Miserlou merged commit 7944793 into dev Jun 18, 2018
@wvauclain wvauclain deleted the miserlou/telemetry branch July 9, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants