Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add screenshot button #527

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

dbuezas
Copy link
Contributor

@dbuezas dbuezas commented Jul 13, 2023

image

When clicked it downloads a screenshot
image

Button can be removed via config. Let me know if you prefer it to be removed by default.

Closes #524

@dbuezas
Copy link
Contributor Author

dbuezas commented Jul 13, 2023

Unfortunately it doesn't work inside the Android Home Assistant App, but it does in chrome

@dbuezas
Copy link
Contributor Author

dbuezas commented Jul 24, 2023

Maybe it could store it in the media folder instead, wdyt?

@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 9, 2023

There is some hope: the "Download Diagnostics" button from the integration page does download a file from the mobile app. Now we just need to find out what's the mechanism used there

@AlexxIT AlexxIT self-requested a review August 24, 2023 08:22
AlexxIT added a commit that referenced this pull request Aug 24, 2023
@AlexxIT AlexxIT merged commit ed1c8e7 into AlexxIT:master Aug 24, 2023
1 check passed
@AlexxIT
Copy link
Owner

AlexxIT commented Aug 24, 2023

Thanks!

@felipecrs
Copy link
Contributor

There is some hope: the "Download Diagnostics" button from the integration page does download a file from the mobile app. Now we just need to find out what's the mechanism used there

Frigate Card also downloads clips and snapshots just fine on Android Companion, just for reference.

@AlexxIT
Copy link
Owner

AlexxIT commented Aug 24, 2023

Maybe Frigate download remote file. Because this is local in-browser file.
And (of course) this method doesn't work on Safari.

@AlexxIT AlexxIT added this to the v3.3.0 milestone Aug 24, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Aug 24, 2023

@Mr-HaleYa
Copy link

@dbuezas

Button can be removed via config

Is there an easy way to remove just this button without disabling the UI? I keep hitting it on my tablet when I try to do fullscreen and it's not needed on that dashboard.
Works great on my desktop tho!

@felipecrs
Copy link
Contributor

As mentioned in the documentation:

style: '.screenshot {display: none}'

@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 26, 2023

The buttons are indeed very small for touch devices.
You could add a media query in the custom style too:

style: |
  media (hover: none) {
    .screenshot {
      display: none;
    }
  }

(Not tested)

At some point I hope to make it work in mobile too :)

@AlexxIT
Copy link
Owner

AlexxIT commented Aug 26, 2023

Screenshot works for me on Android Chrome

@dbuezas
Copy link
Contributor Author

dbuezas commented Aug 26, 2023

Oh wow! It works for me too! There must have been a change in the Home Assistant frontend.

What a pleasant surprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Save snapshot button
4 participants