Add telnet_password
for ShellE1
and ShellMGW2
#1454
+34
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
telnet_password
in ConfigFlow, only tested onMijia_Hub_V2
.It's not safe to set a empty password for root user, Gateway exposes telnet port in the public network, especially in IPv6 network.
README.md
Telnet Password - gateway(
Aqara_Hub_E1
orMijia_Hub_V2
) telnet password. Password will setup while adding integration(keep field empty if you don't want setup password), or you need change both integration config and password in telnet(passwd
orchpasswd
) later.Config
Issues
Known issue
If
telnet_password
is configured and not empty, user can not reconfiguretelnet_password
to empty, I'm not familiar with Python, maybe you can fix it. :-)