Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using piped backchannel without consumers leads to nil #1080

Closed
slyoldfox opened this issue May 2, 2024 · 2 comments
Closed

Using piped backchannel without consumers leads to nil #1080

slyoldfox opened this issue May 2, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@slyoldfox
Copy link

slyoldfox commented May 2, 2024

Using the following from the example config:

streams:
    play_pcm48k: exec:ffplay -fflags nobuffer -f s16be -ar 48000 -i -#backchannel=1

And visiting https://localhost/stream.html?src=play_pcm48k will return in a nil pointer exception on c.cmd.Process.Kill

return errors.Join(p.Closer.Close(), p.cmd.Process.Kill(), p.cmd.Wait())

c.cmd.Process is nil in my case.

I am guessing this is caused by the producers being closed down before the command has spawn.
The producers are shut down because there are no consumers triggered by:

https://github.com/AlexxIT/go2rtc/blob/master/internal/streams/add_consumer.go#L86

@slyoldfox
Copy link
Author

This is on 1.9.0 on macos (intel)

slyoldfox added a commit to slyoldfox/go2rtc that referenced this issue May 2, 2024
@AlexxIT AlexxIT added the bug Something isn't working label May 3, 2024
@AlexxIT AlexxIT added this to the v1.9.1 milestone May 5, 2024
@AlexxIT
Copy link
Owner

AlexxIT commented May 6, 2024

https://github.com/AlexxIT/go2rtc/releases/tag/v1.9.1

@AlexxIT AlexxIT closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants