Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RTSP server close (panic) without client request #364

Closed
AlexxIT opened this issue Apr 18, 2023 · 1 comment
Closed

Fix RTSP server close (panic) without client request #364

AlexxIT opened this issue Apr 18, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@AlexxIT
Copy link
Owner

AlexxIT commented Apr 18, 2023

Creating go2rtc ... done
01:02:47.821 INF go2rtc version 1.3.2 linux/amd64
01:02:47.821 INF [api] listen addr=:1984
01:02:47.821 INF [rtsp] listen addr=:8554
01:02:47.822 INF [srtp] listen addr=:8443
01:02:47.822 INF [webrtc] listen addr=:8555

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x674e40]

goroutine 5 [running]:
net/url.(*URL).String(0x0)
        net/url/url.go:810 +0x40
github.com/AlexxIT/go2rtc/pkg/tcp.(*Request).String(0xc00007e050)
        github.com/AlexxIT/go2rtc/pkg/tcp/textproto.go:96 +0x3d
github.com/AlexxIT/go2rtc/pkg/tcp.(*Request).Write(0xc10791e7affed6d0?, {0xd43780, 0xc000012010})
        github.com/AlexxIT/go2rtc/pkg/tcp/textproto.go:108 +0x25
github.com/AlexxIT/go2rtc/pkg/rtsp.(*Conn).WriteRequest(0xc0000ac000, 0xc00007e050)
        github.com/AlexxIT/go2rtc/pkg/rtsp/conn.go:291 +0x456
github.com/AlexxIT/go2rtc/pkg/rtsp.(*Conn).Teardown(...)
        github.com/AlexxIT/go2rtc/pkg/rtsp/client.go:287
github.com/AlexxIT/go2rtc/pkg/rtsp.(*Conn).Close(0xc0000ac000)
        github.com/AlexxIT/go2rtc/pkg/rtsp/client.go:291 +0x65
github.com/AlexxIT/go2rtc/cmd/rtsp.tcpHandler(0xc0000ac000)
        github.com/AlexxIT/go2rtc/cmd/rtsp/rtsp.go:223 +0x237
created by github.com/AlexxIT/go2rtc/cmd/rtsp.Init.func1
        github.com/AlexxIT/go2rtc/cmd/rtsp/rtsp.go:74 +0x48

From #355 (comment)

@AlexxIT AlexxIT added the bug Something isn't working label Apr 18, 2023
@AlexxIT AlexxIT pinned this issue Apr 18, 2023
@AlexxIT AlexxIT changed the title Panic on RTSP stream Close Fix RTSP server close (panic) without client request Apr 19, 2023
@AlexxIT AlexxIT self-assigned this Apr 19, 2023
@AlexxIT AlexxIT unpinned this issue Apr 19, 2023
@AlexxIT
Copy link
Owner Author

AlexxIT commented Apr 23, 2023

@AlexxIT AlexxIT closed this as completed Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant