Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: templates and better filter support for #raw #487

Closed
chatziko opened this issue Jun 25, 2023 · 4 comments
Closed

Enhancement: templates and better filter support for #raw #487

chatziko opened this issue Jun 25, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@chatziko
Copy link

#raw is super useful, but currently has 2 limitations

  • no template support
  • cannot use -vf in cases when go2rtc adds its own filters (ffmpeg only accepts a single -vf)

So I propose the following:

  1. Add template support: #raw=my_template should be expanded if a template my_template exists.
  2. If raw (after expansion) contains -vf then go2rtc should not insert its own filters, it's the user's responsibility to add all filters in the proper order.

A possible use case is #402, but I can imagine many others, raw/filters are very general features.

@AlexxIT AlexxIT added the enhancement New feature or request label Jun 25, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Jun 25, 2023

#filter=value also good idea

@chatziko
Copy link
Author

#filter=value also good idea

Indeed, in fact I started writing this issue after my comment in #402 to suggest #filter=value.

But then I realized a problem: in what order should the user filters be combined with the generated ones? Say #hardware adds hwupload, I might want to add a filter either before or after. So maybe its easier to let the user supply all filters without merging, in which case #raw is already sufficient, no need to introduce #filter.

@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2023

@AlexxIT AlexxIT closed this as completed Jul 11, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2023

I made support for software filters + hardware encoding. Hopefully this solves the problem mentioned.

felipecrs pushed a commit to felipecrs/go2rtc that referenced this issue Oct 20, 2023
felipecrs pushed a commit to felipecrs/go2rtc that referenced this issue Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants