Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(streams): handle interface conversion panic in NewStream() at internal/streams #1009

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

skrashevich
Copy link
Contributor

@skrashevich skrashevich commented Mar 19, 2024

panic: interface conversion: interface {} is map[string]interface {}, not string

goroutine 1 [running]:
github.com/AlexxIT/go2rtc/internal/streams.NewStream({0x1010ef3e0?, 0x140001305b8?})
        /Users/svk/Documents/GitHub/go2rtc/internal/streams/stream.go:26 +0x3b0
github.com/AlexxIT/go2rtc/internal/streams.Init()
        /Users/svk/Documents/GitHub/go2rtc/internal/streams/streams.go:26 +0x134
main.main()
        /Users/svk/Documents/GitHub/go2rtc/main.go:46 +0x28
exit status 2

Now the configuration like this causing a crash at startup. this PR fix it

streams:
  - exec: "ffmpeg -i 'https://camera.lipetsk.ru/ms-25.camera.lipetsk.ru/live/6a3efc18-3651-43a4-b164-d07543151c3b/playlist.m3u8' -c:v libx264 -pix_fmt yuv420p -b:v 2368512 -f rtsp {output}"

@AlexxIT AlexxIT self-assigned this Apr 22, 2024
@AlexxIT AlexxIT merged commit 1682d18 into AlexxIT:master Apr 29, 2024
@AlexxIT
Copy link
Owner

AlexxIT commented Apr 29, 2024

Thanks!

@skrashevich skrashevich deleted the fix-new-stream-error branch April 29, 2024 03:37
@AlexxIT AlexxIT added this to the v1.9.0 milestone Apr 29, 2024
@AlexxIT
Copy link
Owner

AlexxIT commented Apr 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants