Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hardware.Dockerfile for multi-platform support #414

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Update hardware.Dockerfile for multi-platform support #414

merged 1 commit into from
Jul 6, 2023

Conversation

skrashevich
Copy link
Contributor

@skrashevich skrashevich commented May 4, 2023 •
edited
Loading

...because we can build from hardware.Dockerfile on non-amd64 host, such as Apple M1

@AlexxIT
Copy link
Owner

AlexxIT commented May 5, 2023

What's the point to run this image on M1?
This image with drivers for Intel, AMD and Nvidia. They useless on M1

@skrashevich
Copy link
Contributor Author

this command will build go2rtc-hardware container for generic amd64 platform on your arm64 MacBook (for example):
docker buildx build --platforms=linux/amd64 -t alexxit/go2rtc:master-hardware -f hardware.Dockerfile --push .
and then you can use it where you want, on any amd64 system

@AlexxIT
Copy link
Owner

AlexxIT commented Jun 29, 2023

What about?

ARG TARGETPLATFORM
ARG TARGETOS
ARG TARGETARCH

Looks like TARGETPLATFORM not used. And TARGETOS and TARGETARCH not set anywhere.

@skrashevich
Copy link
Contributor Author

skrashevich commented Jul 1, 2023 •
edited
Loading

And TARGETOS and TARGETARCH not set anywhere.

they set by buildkit (it's integrated args, like BUILDPLATFORM)

Looks like TARGETPLATFORM not used

Yes, really

@AlexxIT
Copy link
Owner

AlexxIT commented Jul 6, 2023

OK. I hope this doesn't break anything.

@AlexxIT AlexxIT merged commit 19130a4 into AlexxIT:master Jul 6, 2023
@skrashevich skrashevich deleted the 230504-patch-dockerfile.hardware branch July 6, 2023 12:20
@skrashevich
Copy link
Contributor Author

OK. I hope this doesn't break anything.

I'm too

@skrashevich skrashevich mentioned this pull request Jul 11, 2023
Merged
@AlexxIT AlexxIT added this to the v1.6.0 milestone Jul 11, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2023

https://github.com/AlexxIT/go2rtc/releases/tag/v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@skrashevich @AlexxIT