-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DVRIP discovery #462
Add DVRIP discovery #462
Conversation
Tested on 3 ICSee cameras. |
I confirmed that the single broadcasted "magic hex code" is enough. I did that by analysing network traffic from two mobile apps (ICSee and XMEye Pro) and one desktop app (VMS), they all send only that message when they try to find cams in the network. |
Please check if I'm not break anything with my code refactoring. |
Alright I'll retest it tonight |
I just tested it and can confirm it does still work after your refactoring work. Thanks for taking this in! |
If at some point you want to reduce the code further, I just realised that one could forego the |
The first ever thing I do in Go so I'm expecting to have to make some changes after your feedback.
I reverse engineered the discovery protocol with Wireshark and my 3 cameras, hence the magic hex stream broadcasted and the discarded first 20 bytes of the responses.