Add DVRIP discovery #462
Merged
Add DVRIP discovery #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on 3 ICSee cameras. |
|
I confirmed that the single broadcasted "magic hex code" is enough. I did that by analysing network traffic from two mobile apps (ICSee and XMEye Pro) and one desktop app (VMS), they all send only that message when they try to find cams in the network. |
|
Please check if I'm not break anything with my code refactoring. |
|
Alright I'll retest it tonight |
|
I just tested it and can confirm it does still work after your refactoring work. Thanks for taking this in! |
|
If at some point you want to reduce the code further, I just realised that one could forego the |
felipecrs
pushed a commit
to felipecrs/go2rtc
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first ever thing I do in Go so I'm expecting to have to make some changes after your feedback.
I reverse engineered the discovery protocol with Wireshark and my 3 cameras, hence the magic hex stream broadcasted and the discarded first 20 bytes of the responses.