Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FFmpeg params in some cases #510

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Conversation

horttorrell32
Copy link

If only a input parameter is defined, the 'Process video/audio codecs' choose '-vn -an' instead of '-c copy'.
E.g.:
ffmpeg:rtsp://example.com#input=rtsp/udp
=>
ffmpeg -hide_banner -allowed_media_types video+audio -fflags nobuffer -flags low_delay -timeout 5000000 -user_agent go2rtc/ffmpeg -i rtsp://example.com -vn -an -user_agent ffmpeg/go2rtc -rtsp_transport tcp -f rtsp {output}

I also add ffmpeg_test to try to check all current cases.

Galindo, Alex added 6 commits July 6, 2023 10:25
Correct the Input Template to delete the 'input' parameter to allow set the copy codecs option, otherwise the '-vn -an' codecs option is selected.
Some HTTP (a.g. JPEG or MJPEG) needs set the input framerate explicitly.
AlexxIT added a commit that referenced this pull request Jul 10, 2023
@AlexxIT AlexxIT merged commit a79fe60 into AlexxIT:master Jul 10, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Jul 10, 2023

Thanks. I've changed the implementation a bit.

AlexxIT added a commit that referenced this pull request Jul 10, 2023
@AlexxIT AlexxIT changed the title Correct issue of input parameter of ffpmeg Fix FFmpeg params in some cases Jul 11, 2023
@AlexxIT AlexxIT added this to the v1.6.0 milestone Jul 11, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Jul 11, 2023

felipecrs pushed a commit to felipecrs/go2rtc that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants