Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FFmpeg flags for hardware vaapi #557

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

h0nIg
Copy link
Contributor

@h0nIg h0nIg commented Aug 1, 2023

Hi,

i just started to use go2rtc and came across an issue with h264 and the baseline profile. It looks like some streams over-declare their required capabilities

https://github.com/FFmpeg/FFmpeg/blob/0e9956a06e9307e01232bc354665fadf6f7a09df/libavcodec/options_table.h#L402C1-L403C1

// Allowing a profile mismatch can be useful because streams may
 // over-declare their required capabilities - in particular, many
// H.264 baseline profile streams (notably some of those in FATE)
// only use the feature set of constrained baseline.

Therefore it is a good idea to add this parameter to be more resillient. On top of that "raw" option does not work as the following error will be thrown:

Codec AVOption hwaccel_flags () is not an encoding option.

@skrashevich
Copy link
Contributor

you can manipulate input parameters via "#input" option, not "#raw"

from readme:

You can use input param to override default input template (ex. #input=rtsp/udp will change RTSP transport from TCP to UDP+TCP)
You can use raw input value (ex. #input=-timeout 5000000 -i {input})
You can add your own input templates

@AlexxIT AlexxIT force-pushed the master branch 4 times, most recently from 50492e5 to 279d8bf Compare August 20, 2023 20:41
@AlexxIT AlexxIT merged commit 357e7c1 into AlexxIT:master Aug 23, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Aug 23, 2023

Thanks!

@AlexxIT AlexxIT changed the title fix known problem of wrong profile declaration capabilities Update FFmpeg flags for hardware vaapi Sep 2, 2023
@AlexxIT AlexxIT added this to the v1.7.0 milestone Sep 2, 2023
@AlexxIT
Copy link
Owner

AlexxIT commented Sep 2, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants