New attribute for FileSelect control to filter allowed file MIME-types #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great pull request - really happy to have this provided. Although there's no unit test, you've updated the test page to make it easy to verify manually (and it's not possible to automate these tests anyway)... I'll be very happy to merge this is you update the since annotations to be 1.0.79. |
| * @instance | ||
| * @type {string} | ||
| * @default | ||
| * @since 1.0.? |
|
Thanks for making those changes so quickly, and thanks again for the pull request - it's greatly appreciated! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New attribute in FileSelect control and FileInput widget to support "accept" attribute for tag: http://www.w3schools.com/tags/att_input_accept.asp
P.S. Please don't be evil, it's my first pull request that is not about russian l10n. Also looks like my IDE updated some line breaks.