Make hard-coded topics for sort requests / field selection configurable #1361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, a safe, backwards compatible improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1352
This PR addresses the points I reported in #1352. I have update all relevant references to topics.SORT_LIST to use an instance-configurable property instead which is by default initialised to the value of the topic constant, thus keeping backwards compatibility. In one instance I also corrected an incorrect use of the topics.UPDATE_LIST_SORT_FIELD constant when a relevant instance-level property already existed. For the SortOrderToggle module I had to move the
onConfig/offConfigdefault override into a newpostMixInPropertiesto deal with the configurableselectionTopicso users of this module are not forced to override/configure those two properties just because they configured a differentselectionTopic.