AFI-1520:Externalize required parameters for build in build-and-relea… #255
Conversation
…se-maven.yml in the alfresco-build-tools project
…se-maven.yml in the alfresco-build-tools project;adding new line at end
…se-maven.yml in the alfresco-build-tools project;perhaps fix the End of line issue
|
Here is the link of the CI file of our project - https://github.com/Alfresco/sap-content-connector-parent/blob/feature/AFI-568/.github/workflows/ci.yml This file is just for some testing at this moment. And also, for testing purpose, we created a local copy of the build-and-release-maven.yml which is referenced from the ci.yml at this moment. Thanks in advance! |
…se-maven.yml in the alfresco-build-tools project;removing the trailing space from step name
There was a problem hiding this comment.
Since this action is being used in several repositories, it would be very important to have a link to an example workflow run where we don't pass any of the newly added parameters to verify that it still works as expected (installs the default Java version, computes the release and development version automatically) and this change won't break pre-existing workflows that get bumped to the latest version of this action.
…se-maven.yml in the alfresco-build-tools project;incorporated review comments
…se-maven.yml in the alfresco-build-tools project;perhaps fix the CI/test
…se-maven.yml in the alfresco-build-tools project;perhaps fix the CI/test
|
Updated the PR as per the review comments. Following are the sample workflows which consume this build-and-release-maven workflow.
Please let me know if any additional change is required. |
| java-version: ${{ inputs.java-version}} | ||
| java-distribution: ${{ inputs.java-distribution}} |
There was a problem hiding this comment.
| java-version: ${{ inputs.java-version}} | |
| java-distribution: ${{ inputs.java-distribution}} | |
| java-version: ${{ inputs.java-version }} | |
| java-distribution: ${{ inputs.java-distribution }} |
…se-maven.yml in the alfresco-build-tools project;adding space
We need to externalize the following parameters for building the sap-connector projects,
While incorporating the required change, I found an issue of GitHub action while differentiating the input parameter between empty or not set in a reusable workflow and it is already an open issue at GitHub. Here is the reference - actions/runner#924
Hence, I needed to do it using condition construct.
Thank you!