Pronin Arkadiy's Tasks #29
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <iostream> | ||
| #include <stdexcept> | ||
|
|
||
| #define UNREACHABLE (-1) |
There was a problem hiding this comment.
warning: macro 'UNREACHABLE' defines an integral constant; prefer an enum instead [cppcoreguidelines-macro-to-enum]
#define UNREACHABLE (-1)
^| #include <stdexcept> | ||
|
|
||
| #define UNREACHABLE (-1) | ||
|
|
There was a problem hiding this comment.
warning: replace macro with enum [cppcoreguidelines-macro-to-enum]
| enum { | |
| UNREACHABLE = (-1)}; | |
|
|
||
| void Graph::PrintGraph() const { | ||
| if (vertexes_num == 0) { | ||
| std::cerr << "Error: Graph is empty." << std::endl; |
There was a problem hiding this comment.
warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl]
| std::cerr << "Error: Graph is empty." << std::endl; | |
| std::cerr << "Error: Graph is empty." << '\n'; |
| return dst; | ||
| } | ||
|
|
||
| void Dijkstra(int v, int from, vector<int>& vis, vector<int>& dst, |
There was a problem hiding this comment.
warning: parameter 'from' is unused [misc-unused-parameters]
| void Dijkstra(int v, int from, vector<int>& vis, vector<int>& dst, | |
| void Dijkstra(int v, int /*from*/, vector<int>& vis, vector<int>& dst, |
| return dst; | ||
| } | ||
|
|
||
| void Dijkstra(int v, int from, vector<int>& vis, vector<int>& dst, |
There was a problem hiding this comment.
warning: parameter 'vis' is unused [misc-unused-parameters]
| void Dijkstra(int v, int from, vector<int>& vis, vector<int>& dst, | |
| void Dijkstra(int v, int from, vector<int>& /*vis*/, vector<int>& dst, |
| } | ||
|
|
||
| void Dijkstra(int v, int from, vector<int>& vis, vector<int>& dst, | ||
| const AdjacencyList adj) { |
There was a problem hiding this comment.
warning: the const qualified parameter 'adj' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param]
lib/src/util.hpp:9:
- const AdjacencyList);
+ const AdjacencyList&);| const AdjacencyList adj) { | |
| const AdjacencyList& adj) { |
Pronin Arkadiy's Tasks