Done homework_1 #18
Open
Done homework_1 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LostPointer
requested changes
Mar 2, 2024
task_01/src/main.cpp
Outdated
| int main() { return 0; } | ||
| #include "topology_sort.hpp" | ||
|
|
||
| long long GetSize() { |
There was a problem hiding this comment.
лучше смотрится size_t для размеров массива
task_01/src/main.cpp
Outdated
| } | ||
|
|
||
| int main() { | ||
| long long n = GetNumber(); |
There was a problem hiding this comment.
давай не будем называть переменные одной буквой
task_01/src/topology_sort.cpp
Outdated
|
|
||
| std::pair<long long, long long> GetTwoNums(long long n, | ||
| std::vector<long long> nums) { | ||
| size_t l = 0; |
There was a problem hiding this comment.
однобуквенные переменные(
LostPointer
requested changes
Mar 23, 2024
task_01/src/topology_sort.cpp
Outdated
| std::pair<long long, long long> GetTwoNums(long long number, | ||
| std::vector<long long> nums) { | ||
| if (nums.size() <= 1) { | ||
| return {-1, -1}; |
There was a problem hiding this comment.
кажется лучше тогда кинуть исключение
task_01/src/topology_sort.cpp
Outdated
task_01/src/test.cpp
Outdated
| TEST(GetTwoNums, Test_10) { | ||
| ASSERT_EQ(GetTwoNums(100, std::vector<long long>{}), | ||
| (std::pair<long long, long long>{-1, -1})); | ||
| } |
There was a problem hiding this comment.
не хватает теста если в массиве нет чисел дающие в сумме нужное число
LostPointer
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.