Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 matchers for headers #160

Merged
merged 2 commits into from Mar 15, 2016
Merged

Added 2 matchers for headers #160

merged 2 commits into from Mar 15, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 15, 2016

Added a matcher to check if an NSURLRequest has a header set for a key
Added a matcher to check if an NSURLRequest has a header set for a key and that it's value matches a value passed in.

…resent, and a matcher to check if a request has a header with a key and value.
@AliSoftware
Copy link
Owner

Great thanks for the PR! 👌

Could you add an entry (under some ## Master title) in the CHANGELOG.md to credit yourself? Thx!

@ghost
Copy link
Author

ghost commented Mar 15, 2016

Awesome!

Sorry not sure I understand what you mean by some ## Master title. Could you possibly give an example?

@AliSoftware
Copy link
Owner

The CHANGELOG have titles for each version, like ## 4.8.0 and ## 4.7.0 etc.
So tTo add a new entry, you'll simply need to add a section for "Master" (rather than, e.g. add a section named "4.9.0" or whatnot — since I don't know when I'll release a new version and what this next version will contain, so we can't know in advance what the next version number/name is gonna be).

## Master

* <Description of your changes here>.  
  [@<yourGitHubHandle>](<YourGitHubProfileURL>), [#160](https://github.com/AliSoftware/OHHTTPStubs/pull/160)

Note: in order for GitHub's markdown to go to the next line between your entry description and the line with your name and PR link, you'll have to end the description line with two spaces (see other entries in the CHANGELOG for inspiration)

@ghost
Copy link
Author

ghost commented Mar 15, 2016

Great, thank you! Will do that now.

@AliSoftware
Copy link
Owner

👍

AliSoftware added a commit that referenced this pull request Mar 15, 2016
@AliSoftware AliSoftware merged commit a97ebe7 into AliSoftware:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant