Adds more logging blocks for debugging and extended features #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, was CI disabled for this project? |
|
Thanks a lot for this PR! Looks quite good! 👍 I don't know why Travis didn't pick up that PR, it usually does (it did for the last PR 160, so why not this one?), so that's strange indeed. Could you also add an entry in the |
|
CI ran this time! |
|
Thank you! That's an easy fix |
AliSoftware
added a commit
that referenced
this pull request
Mar 19, 2016
Adds more logging blocks for debugging and extended features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a large change, but I was hoping for a little more insight into when certain actions occur inside OHHTTPStubs so I added some more blocks in addition to
onStubActivationBlock. Now there is also aonStubRedirectBlockand aafterStubFinishBlockfor better clarity. As well, I pass in the response used by the stub. In my case I use single stub that generates multiple different responses, similar to your example Different responses for each call and so it was easier to track the response returned than the descriptor that generates that response.I'm totally open to a discussion on this, but it'd be really helpful for me if something like this was added, hence why I put together this PR.